Deep object update consistency#3847
Merged
soyuka merged 2 commits intoNov 30, 2020
Merged
Conversation
soyuka
commented
Nov 26, 2020
soyuka
commented
Nov 26, 2020
alanpoulain
reviewed
Nov 26, 2020
alanpoulain
reviewed
Nov 26, 2020
soyuka
force-pushed
the
fix/abstract-normalizer-constructor-2
branch
6 times, most recently
from
November 26, 2020 12:45
f1b2e0f to
5db20d5
Compare
dunglas
reviewed
Nov 26, 2020
soyuka
force-pushed
the
fix/abstract-normalizer-constructor-2
branch
3 times, most recently
from
November 26, 2020 14:41
4f3a8ec to
8608271
Compare
soyuka
commented
Nov 29, 2020
soyuka
commented
Nov 29, 2020
soyuka
force-pushed
the
fix/abstract-normalizer-constructor-2
branch
from
November 29, 2020 17:45
2a6e000 to
8f37049
Compare
soyuka
force-pushed
the
fix/abstract-normalizer-constructor-2
branch
2 times, most recently
from
November 29, 2020 20:02
9775a97 to
3f25711
Compare
soyuka
force-pushed
the
fix/abstract-normalizer-constructor-2
branch
from
November 30, 2020 13:57
f953a0b to
cb7cf2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip_null_valuesThis PR fixes inconsistencies when updating deep objects. In an update context, we should always set the
deep_object_to_populate, at least for theapplication/merge-patch+jsoncontent type.Note that this fixes incoherent behavior for PATCH when updating nested resources.
Also, now we support
deep_object_to_populateand this fixes #3087. Users can enable it via thedenormalization_contextif needed.Many thanks @Toflar for reporting this and helping me get to the bottom of this!